cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...
Date Fri, 30 Oct 2015 16:40:22 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1009#discussion_r43523817
  
    --- Diff: framework/db/src/com/cloud/utils/db/Filter.java ---
    @@ -89,7 +89,7 @@ public void addOrderBy(Class<?> clazz, String field, boolean ascending)
{
             if (_orderBy == null) {
                 _orderBy = order.insert(0, " ORDER BY ").toString();
             } else {
    -            _orderBy = order.insert(0, _orderBy).toString();
    +            _orderBy = order.insert(0, _orderBy + ", ").toString();
    --- End diff --
    
    LGTM, but since this is a core change can you write a small unit test for this method?
For the list template api, the temp_zone_pair should give a unique id (template_id + "_" +
zone_id) so sorting on this should give us deterministic results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message