cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...
Date Tue, 27 Oct 2015 20:44:39 GMT
Github user borisroman commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/989#discussion_r43184047
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -602,9 +610,8 @@ def compare(self, bag):
                 if self.dev in bag.keys():
                     for address in bag[self.dev]:
                         self.setAddress(address)
    -                    if self.hasIP(ip):
    -                        found = True
    -                    if self.is_guest_gateway(address, ip):
    +                    if (self.hasIP(ip) or self.is_guest_gateway(address, ip)) and addess["add"]:
    +                        logging.debig("The IP address in '%s' will be configured" % address)
    --- End diff --
    
    Is logging.debig correct? Shouldn't this be logging.debug?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message