cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nlivens <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Tue, 27 Oct 2015 08:33:11 GMT
Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43093940
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -303,13 +414,17 @@ protected boolean canHandle(Network network, Service service) {
             }
     
             if (!_networkModel.isProviderForNetwork(getProvider(), network.getId())) {
    -            s_logger.debug("NuageElement is not a provider for network " + network.getDisplayText());
    +            if (s_logger.isDebugEnabled()) {
    +                s_logger.debug("NuageVsp is not a provider for network " + network.getDisplayText());
    +            }
                 return false;
             }
     
             if (service != null) {
                 if (!_ntwkSrvcDao.canProviderSupportServiceInNetwork(network.getId(), service,
getProvider())) {
    -                s_logger.debug("NuageElement can't provide the " + service.getName()
+ " service on network " + network.getDisplayText());
    +                if (s_logger.isDebugEnabled()) {
    +                    s_logger.debug("NuageVsp can't provide the " + service.getName()
+ " service on network " + network.getDisplayText());
    --- End diff --
    
    This code is just checking whether the NuageVsp provider supports the services enabled
on the given network, no need for specific information about the Nuage VSP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message