cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nlivens <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Tue, 27 Oct 2015 08:17:49 GMT
Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43092950
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
    @@ -58,20 +73,117 @@ public String getVpcOrSubnetUuid() {
             return _vpcOrSubnetUuid;
         }
     
    -    public boolean isL3Network() {
    -        return _isL3Network;
    +    public String getNetworkName() {
    +        return _networkName;
    +    }
    +
    +    public boolean isL2Network() {
    +        return _isL2Network;
         }
     
         public List<Map<String, Object>> getAclRules() {
             return _aclRules;
         }
     
    -    public boolean isVpc() {
    -        return _isVpc;
    +    public long getNetworkId() {
    +        return _networkId;
         }
     
    -    public long getNetworkId() {
    -        return this._networkId;
    +    public boolean isEgressDefaultPolicy() {
    +        return _egressDefaultPolicy;
    +    }
    +
    +    public Boolean getAcsIngressAcl() {
    +        return _acsIngressAcl;
    +    }
    +
    +    public boolean isNetworkReset() {
    +        return _networkReset;
    +    }
    +
    +    public String getDomainTemplateName() {
    +        return _domainTemplateName;
    +    }
    +
    +    public static class Builder implements CmdBuilder<ApplyAclRuleVspCommand> {
    --- End diff --
    
    No, there shouldn't be any default values in my opinion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message