cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 26 Oct 2015 19:56:53 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43043984
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
    @@ -129,66 +132,93 @@ public Network design(NetworkOffering offering, DeploymentPlan plan,
Network use
     
         @Override
         public Network implement(Network network, NetworkOffering offering, DeployDestination
dest, ReservationContext context) throws InsufficientVirtualNetworkCapacityException {
    +        long networkId = network.getId();
    +        network = _networkDao.acquireInLockTable(network.getId(), 1200);
    +        if (network == null) {
    +            throw new ConcurrentOperationException("Unable to acquire lock on network
" + networkId);
    +        }
    +
    +        NetworkVO implemented = null;
    +        try {
    +            assert (network.getState() == State.Implementing) : "Why are we implementing
" + network;
    --- End diff --
    
    Personally, I love assertions.  However, as a project, we don't consistently run with
assertions enabled.  Additionally, the incomplete test coverage does not guarantee that the
assertion will properly exercised.  Therefore, I suggest converting into an ``if`` block and
throw an ``IllegalStateException`` to ensure that the conditions is always checked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message