cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 26 Oct 2015 19:43:22 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43042353
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -367,22 +483,16 @@ public boolean applyStaticNats(Network config, List<? extends
StaticNat> rules)
                 sourceNatDetail.put("sourceNatVlanNetmask", sourceNatVan.getVlanNetmask());
                 sourceNatDetails.add(sourceNatDetail);
             }
    -        try {
    -            try {
    -                HostVO nuageVspHost = getNuageVspHost(config.getPhysicalNetworkId());
    -                ApplyStaticNatVspCommand cmd = new ApplyStaticNatVspCommand(networkDomain.getUuid(),
vpcOrSubnetUuid, isL3Network, sourceNatDetails);
    -                ApplyStaticNatVspAnswer answer = (ApplyStaticNatVspAnswer)_agentMgr.easySend(nuageVspHost.getId(),
cmd);
    -                if (answer == null || !answer.getResult()) {
    -                    s_logger.error("ApplyStaticNatNuageVspCommand for network " + config.getUuid()
+ " failed");
    -                    if ((null != answer) && (null != answer.getDetails())) {
    -                        throw new ResourceUnavailableException(answer.getDetails(), Network.class,
config.getId());
    -                    }
    -                }
    -            } catch (Exception e) {
    -                s_logger.warn("Failed to apply static Nat in Vsp " + e.getMessage());
    +
    +        HostVO nuageVspHost = getNuageVspHost(config.getPhysicalNetworkId());
    +        ApplyStaticNatVspCommand.Builder cmdBuilder = new ApplyStaticNatVspCommand.Builder().networkDomainUuid(networkDomain.getUuid())
    --- End diff --
    
    Consider placing each method call to the builder on a single line to make the code more
readable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message