cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 26 Oct 2015 19:39:09 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43041851
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -194,7 +224,23 @@ public boolean configure(String name, Map<String, Object> params)
throws Configu
         @Override
         public boolean implement(Network network, NetworkOffering offering, DeployDestination
dest, ReservationContext context) throws ConcurrentOperationException,
                 ResourceUnavailableException, InsufficientCapacityException {
    -        s_logger.debug("Entering NuageElement implement function for network " + network.getDisplayText()
+ " (state " + network.getState() + ")");
    +        if (s_logger.isDebugEnabled()) {
    +            s_logger.debug("Entering NuageElement implement function for network " +
network.getDisplayText() + " (state " + network.getState() + ")");
    +        }
    +
    +        if (network.getVpcId() != null) {
    +            List<NetworkACLItemVO> rules;
    +            if (network.getNetworkACLId() != null) {
    +                rules = _networkACLItemDao.listByACL(network.getNetworkACLId());
    +            } else {
    +                rules = Collections.emptyList();
    +            }
    --- End diff --
    
    Consider pushing the lines 233-237 down into NetworKACLItemDAO.listByACL(long) to encapsulate
the rule regarding ``null`` ACL IDs and consistency behavior across all uses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message