cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 26 Oct 2015 18:19:22 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43031706
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java
---
    @@ -17,28 +17,38 @@
     // under the License.
     //
     
    -package com.cloud.agent.api.guru;
    -
    -import java.util.List;
    -import java.util.Map;
    +package com.cloud.agent.api.sync;
     
     import com.cloud.agent.api.Answer;
    -import com.cloud.agent.api.Command;
     
    -public class ReserveVmInterfaceVspAnswer extends Answer {
    +public class SyncDomainAnswer extends Answer {
    +
    +    private final boolean _success;
     
    -    public List<Map<String, String>> _interfaceDetails;
    +    public SyncDomainAnswer(boolean success) {
    +        super();
    +        this._success = success;
    +    }
     
    -    public ReserveVmInterfaceVspAnswer(Command cmd, List<Map<String, String>>
interfaceDetails, String details) {
    -        super(cmd, true, details);
    -        this._interfaceDetails = interfaceDetails;
    +    public boolean getSuccess() {
    +        return _success;
         }
     
    -    public ReserveVmInterfaceVspAnswer(Command cmd, Exception e) {
    -        super(cmd, e);
    +
    +    @Override
    +    public boolean equals(Object o) {
    +        if (this == o) return true;
    +        if (o == null || getClass() != o.getClass()) return false;
    +
    +        SyncDomainAnswer that = (SyncDomainAnswer) o;
    +
    +        if (_success != that._success) return false;
    +
    +        return true;
         }
     
    -    public List<Map<String, String>> getInterfaceDetails() {
    -        return this._interfaceDetails;
    +    @Override
    +    public int hashCode() {
    --- End diff --
    
    This ``hashCode`` implementation should include attributes from the ``Command`` super
class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message