cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 26 Oct 2015 18:18:47 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43031615
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionCommand.java
---
    @@ -17,38 +17,42 @@
     // under the License.
     //
     
    -package com.cloud.agent.api.guru;
    +package com.cloud.agent.api.manager;
     
     import com.cloud.agent.api.Command;
     
    -public class ReleaseVmVspCommand extends Command {
    +public class SupportedApiVersionCommand extends Command {
     
    -    String _networkUuid;
    -    String _vmUuid;
    -    String _vmInstanceName;
    +    private final String _apiVersion;
     
    -    public ReleaseVmVspCommand(String networkUuid, String vmUuid, String vmInstanceName)
{
    +    public SupportedApiVersionCommand(String apiVersion) {
             super();
    -        this._networkUuid = networkUuid;
    -        this._vmUuid = vmUuid;
    -        this._vmInstanceName = vmInstanceName;
    +        this._apiVersion = apiVersion;
         }
     
    -    public String getNetworkUuid() {
    -        return _networkUuid;
    +    public String getApiVersion() {
    +        return _apiVersion;
         }
     
    -    public String getVmUuid() {
    -        return _vmUuid;
    +    @Override
    +    public boolean executeInSequence() {
    +        return false;
         }
     
    -    public String getVmInstanceName() {
    -        return _vmInstanceName;
    +    @Override
    +    public boolean equals(Object o) {
    --- End diff --
    
    This ``equals`` implementation should include attributes from the ``Command`` super class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message