cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 26 Oct 2015 17:36:42 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r43025979
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java
---
    @@ -17,18 +17,37 @@
     // under the License.
     //
     
    -package com.cloud.agent.api.element;
    +package com.cloud.agent.api;
     
    -import com.cloud.agent.api.Answer;
    +import com.cloud.host.Host;
     
    -public class ShutDownVpcVspAnswer extends Answer {
    +public class PingNuageVspCommand extends PingCommand {
     
    -    public ShutDownVpcVspAnswer(ShutDownVpcVspCommand cmd, boolean success, String details)
{
    -        super(cmd, success, details);
    +    private final boolean shouldAudit;
    +
    +    public PingNuageVspCommand(Host.Type type, long id, boolean shouldAudit) {
    +        super(type, id);
    +        this.shouldAudit = shouldAudit;
         }
     
    -    public ShutDownVpcVspAnswer(ShutDownVpcVspCommand cmd, Exception e) {
    -        super(cmd, e);
    +    public boolean shouldAudit() {
    +        return shouldAudit;
         }
     
    +    @Override
    +    public boolean equals(Object o) {
    --- End diff --
    
    This equals implementation should include attributes from the ``PingCommand`` super class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message