cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rodrigo93 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...
Date Mon, 26 Oct 2015 16:44:33 GMT
GitHub user rodrigo93 reopened a pull request:

    https://github.com/apache/cloudstack/pull/969

    Fixed return type Void to void in  DataMotionStrategy.

    The main changes are:
    -	Changing methods “Void” to “void”.
    -	Removal of the method “Void copyAsync(DataObject srcData, DataObject
    destData, AsyncCompletionCallback<CopyCommandResult> callback)” that was
    never used.
    We noticed that methods form that class are using the return type Void
    with capital V. This way that method has to return a null value at the
    end. 
    
    Removed trim lines from XenServerStorageMotionStrategy.
    
    The trim lines were removed from XenServerStorageMotionStrategy.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rafaelweingartner/cloudstack master-lrg-cs-hackday-002

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/969.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #969
    
----
commit 781d669dad866ad27a1719edc1b6fe47ce362e16
Author: Rodrigo Marques <rodrigomarques1993@gmail.com>
Date:   2015-10-26T16:42:24Z

    Fixed return type Void to void in DataMotionStrategy.
    
    The main changes are:
    
    Changing methods “Void” to “void”.
    Removal of the method “Void copyAsync(DataObject srcData, DataObject
    destData, AsyncCompletionCallback callback)” that was never used. We
    noticed that methods form that class are using the return type Void with
    capital V. This way that method has to return a null value at the end.
    Removed trim lines from XenServerStorageMotionStrategy.
    
    The trim lines were removed from XenServerStorageMotionStrategy.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message