cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8981 coded a more obscure host...
Date Fri, 23 Oct 2015 17:51:59 GMT
Github user borisroman commented on the pull request:

    https://github.com/apache/cloudstack/pull/965#issuecomment-150646084
  
    Compilation and testing went successfull. As it only involved a change of a unit test,
I hadn't ran integration tests.
    
    ```
    Running com.cloud.utils.rest.BasicRestClientTest
    2015-10-23 18:51:01,522 DEBUG [utils.rest.BasicRestClient] (main:) Executig GET request
on https://fakelocalhost.fakelocaldomain:443/path
    2015-10-23 18:51:01,525 DEBUG [utils.rest.BasicRestClient] (main:) Executig GET request
on https://fakelocalhost.fakelocaldomain:443/path
    2015-10-23 18:51:01,584 DEBUG [utils.rest.BasicRestClient] (main:) Executig GET request
on https://fakelocalhost.fakelocaldomain:443/path
    Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.083 sec - in com.cloud.utils.rest.BasicRestClientTest
    ```
    
    Ping @DaanHoogland @remibergsma 
    
    LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message