cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pvr9711 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...
Date Thu, 22 Oct 2015 10:07:59 GMT
Github user pvr9711 commented on the pull request:

    https://github.com/apache/cloudstack/pull/960#issuecomment-150168452
  
    @miguelaferreira - we have discussed this on an earlier email.  as Prashant said, In this
case a test case is skipped because the setup does not have the configuration needed for the
test to run.  the test will fail if the configuration is incorrect.  From that sense, IMHO
- test setup method is not coded to handle the possibility of configuration not being present
and hence needs a fix.   
    
    Just my 2 cents,  I would like to skip a test if I don't have the configuration.  As a
person running the BVTs, I will check all the test status and cannot ignore skipped tests.
  Also, BVTs are run every time when the build is kicked off.  If people keep adding their
own tests which not everyone can run then the importance of BVTs is gone and we will never
achieve 100% passrate.  If someone has specific tests they want to run, keep it in a different
folder and not keep it in smoke folder. Also, skipping tests is designed for a purpose.  
    
    @runseb we should establish some ground rules around BVTs otherwise we will have to do
conditional coding for running tests which is hard to maintain.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message