cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...
Date Thu, 22 Oct 2015 09:40:16 GMT
Github user miguelaferreira commented on the pull request:

    https://github.com/apache/cloudstack/pull/960#issuecomment-150162817
  
    @nitt10prashant I rather not skip at all. There are just too many examples of tests being
skipped and people not reviewing the output. And that's not even the worse case scenario!
This week I made a PR, I got ! LGTM, Jenkins was green, travis was green and maven wouldn't
even compile the project because I broke it. Builds and test runs breaking when something
is not good is what we need.
    
    And in all fairness, this whole discussion is about not having to give any thought to
which test will run in someone's builds. Why go through all this trouble just to be able to
run all tests in the `test/integration` directory? Will that make ACS better?
    Take the time to figure out which tests you want to run, and if you don't want to run
this one, just don't include it in you build!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message