cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Date Tue, 20 Oct 2015 19:35:21 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/890#issuecomment-149677795
  
    @borisroman, 
    Is this PR intended to fix the ordering of the response of listGuestOsMappingCommand?
    I did not see where you changed the ordering on the SC used. Looking at the changed files
list, I just see you changing types from Long to String.
    
    I noticed that the order by is done in ascending order, using the field “hypervisorType”,
is “hypervisorType” that same as “ostypeid”? Moreover, I could not find a field called
“ostypeid”.  
    
    Interesting that the filtering and the order by was already there, this PR seems to be
related to something else.Is it really a problem to let those field as they are (Long types)?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message