cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From miguelaferreira <...@git.apache.org>
Subject [GitHub] cloudstack pull request: From4.5.1: NSX/Nicira Plugin does not sup...
Date Fri, 16 Oct 2015 07:29:42 GMT
Github user miguelaferreira commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/935#discussion_r42215505
  
    --- Diff: plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java
---
    @@ -180,6 +182,17 @@ public Type getType() {
         public PingCommand getCurrentStatus(final long id) {
             try {
                 ControlClusterStatus ccs = niciraNvpApi.getControlClusterStatus();
    +            //------------------------------------------------GET API_PROVIDER MAJORITY
VERSION
    --- End diff --
    
    if this block is wrapped by a comment, wouldn't it be better to refactor it into a new
method? (giving the method a meaningful name that would render the comment redundant, say
`getApiProviderMajorityVersion(...)`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message