cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Wed, 14 Oct 2015 15:02:41 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r42005230
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java
---
    @@ -0,0 +1,70 @@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +
    +package com.cloud.agent.api.sync;
    +
    +import com.cloud.agent.api.Command;
    +
    +public class SyncNuageVspCmsIdCommand extends Command {
    +
    +    public static enum SyncType { AUDIT, AUDIT_ONLY, REGISTER, UNREGISTER }
    +
    +    private final SyncType _syncType;
    +    private final String _nuageVspCmsId;
    +
    +    public SyncNuageVspCmsIdCommand(SyncType syncType, String nuageVspCmsId) {
    +        super();
    +        this._syncType = syncType;
    +        this._nuageVspCmsId = nuageVspCmsId;
    +    }
    +
    +    public SyncType getSyncType() {
    +        return _syncType;
    +    }
    +
    +    public String getNuageVspCmsId() {
    +        return _nuageVspCmsId;
    +    }
    +
    +    @Override
    +    public boolean executeInSequence() {
    +        return false;
    +    }
    +
    +    @Override
    +    public boolean equals(Object o) {
    +        if (this == o) return true;
    +        if (o == null || getClass() != o.getClass()) return false;
    +
    +        SyncNuageVspCmsIdCommand that = (SyncNuageVspCmsIdCommand) o;
    +
    +        if (_nuageVspCmsId != null ? !_nuageVspCmsId.equals(that._nuageVspCmsId) : that._nuageVspCmsId
!= null)
    +            return false;
    +        if (_syncType != that._syncType) return false;
    +
    +        return true;
    +    }
    +
    +    @Override
    +    public int hashCode() {
    +        int result = _syncType != null ? _syncType.hashCode() : 0;
    +        result = 31 * result + (_nuageVspCmsId != null ? _nuageVspCmsId.hashCode() :
0);
    +        return result;
    +    }
    --- End diff --
    
    @nlivens Looking at the ``Command.toString()`` implementation, I see no reason for it
to be ``final``.  I will open a thread on dev@ to determine if there is a good reason for
it.  If not, I think we should change it, and update these command classes to more detailed
information about their state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message