cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nlivens <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Wed, 14 Oct 2015 13:07:59 GMT
Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41990160
  
    --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java
---
    @@ -21,24 +21,22 @@
     
     import java.util.Collection;
     import java.util.List;
    -import java.util.Map;
     
     public interface NuageVspGuruClient {
     
    -    public void implement(String networkDomainName, String networkDomainPath, String
networkDomainUuid, String networkAccountName, String networkAccountUuid, String networkName,
    -            String networkCidr, String networkGateway, String networkUuid, boolean isL3Network,
String vpcName, String vpcUuid, boolean defaultEgressPolicy,
    -            Collection<String> ipAddressRange) throws Exception;
    +    void implement(String networkDomainName, String networkDomainPath, String networkDomainUuid,
String networkAccountName, String networkAccountUuid, String networkName,
    +                          String networkCidr, String networkGateway, Long networkAclId,
List<String> dnsServers, List<String> gatewaySystemIds, boolean isL3Network, boolean
isVpc, boolean isSharedNetwork,
    +                          String networkUuid, String vpcName, String vpcUuid, boolean
defaultEgressPolicy, Collection<String[]> ipAddressRange, String domainTemplateName)
throws Exception;
    --- End diff --
    
    This is how the methods are declared in our client. They need to have the same signature
as defined in our client.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message