cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nlivens <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Wed, 14 Oct 2015 13:07:48 GMT
Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41990144
  
    --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspApiClient.java
---
    @@ -21,10 +21,10 @@
     
     public interface NuageVspApiClient {
     
    -    public void login() throws Exception;
    +    void login() throws Exception;
     
    -    public void setNuageVspHost(String restRelativePath, String[] cmsUserInfo, int noofRetry,
int retryInterval);
    +    void setNuageVspHost(String restRelativePath, String[] cmsUserInfo, int noofRetry,
int retryInterval, String nuageVspCmsId);
     
    -    public String executeRestApi(String method, String resource, String resourceId, String
childResource, Object entityDetails, String resourceFilter, String proxyUserUuid,
    -            String proxyUserDomainuuid) throws Exception;
    +    String executeRestApi(String method, String resource, String resourceId, String childResource,
Object entityDetails, String resourceFilter, String proxyUserUuid,
    +                                 String proxyUserDomainuuid) throws Exception;
    --- End diff --
    
    This is how the methods are declared in our client. They need to have the same signature
as defined in our client.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message