cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nlivens <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Wed, 14 Oct 2015 12:05:26 GMT
Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41984944
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
    @@ -358,19 +442,28 @@ private String getVirtualRouterIP(Network network, Collection<String>
addressRan
             Set<Long> allIPsInCidr = NetUtils.getAllIpsFromCidr(subnet, cidrSize, new
HashSet<Long>());
     
             if (allIPsInCidr.size() > 3) {
    +            //get the second IP and see if it the networks GatewayIP
                 Iterator<Long> ipIterator = allIPsInCidr.iterator();
                 long vip = ipIterator.next();
                 if (NetUtils.ip2Long(network.getGateway()) == vip) {
    -                s_logger.debug("Gateway of the Network(" + network.getUuid() + ") has
the first IP " + NetUtils.long2Ip(vip));
    +                if (s_logger.isDebugEnabled()) {
    +                    s_logger.debug("Gateway of the Network(" + network.getName() + ")
has the first IP " + NetUtils.long2Ip(vip));
    +                }
                     vip = ipIterator.next();
                     virtualRouterIp = NetUtils.long2Ip(vip);
    -                s_logger.debug("So, reserving the 2nd IP " + virtualRouterIp + " for
the Virtual Router IP in Network(" + network.getUuid() + ")");
    +                if (s_logger.isDebugEnabled()) {
    +                    s_logger.debug("So, reserving the 2nd IP " + virtualRouterIp + "
for the Virtual Router IP in Network(" + network.getName() + ")");
    +                }
                 } else {
                     virtualRouterIp = NetUtils.long2Ip(vip);
    -                s_logger.debug("1nd IP is not used as the gateway IP. So, reserving"
+ virtualRouterIp + " for the Virtual Router IP for " + "Network(" + network.getUuid() + ")");
    +                if (s_logger.isDebugEnabled()) {
    +                    s_logger.debug("1nd IP is not used as the gateway IP. So, reserving"
+ virtualRouterIp + " for the Virtual Router IP for " + "Network(" + network.getName() + ")");
    --- End diff --
    
    Changed the latter message to contain the previous one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message