cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...
Date Wed, 14 Oct 2015 07:19:26 GMT
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/926#discussion_r41961743
  
    --- Diff: server/src/com/cloud/server/StatsCollector.java ---
    @@ -310,8 +326,17 @@ private void init(Map<String, String> configs) {
                 _executor.scheduleAtFixedRate(new VmDiskStatsTask(), vmDiskStatsInterval,
vmDiskStatsInterval, TimeUnit.SECONDS);
             }
     
    +        if (vmNetworkStatsInterval > 0) {
    +            if (vmNetworkStatsInterval < 300)
    --- End diff --
    
    So why is this hardcoded to be at least 300? Shouldn't we at least throw a info log message
here telling the admin that we do this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message