cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...
Date Tue, 13 Oct 2015 20:25:49 GMT
Github user borisroman commented on the pull request:

    https://github.com/apache/cloudstack/pull/923#issuecomment-147841813
  
    @remibergsma @karuturi @wilderrodrigues @DaanHoogland I tested this PR today. Tests ran
fine except for the cleanups (which are known by CLOUDSTACK-8935). I'll spare the space of
this comment as all test results already have been posted twice by Wilder and Remi. I also
ran the test_loadbalance.py which turned out positive.
    
    Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat
| Status : SUCCESS ===
    ok
    Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat
| Status : SUCCESS ===
    ok
    Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb
| Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 3 tests in 633.239s
    
    OK
    /tmp//MarvinLogs/test_loadbalance_HD34OP/results.txt 
    
    Code (style) changes look good to me.
    
    To conclude: LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message