cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 12 Oct 2015 22:24:28 GMT
Github user jburwell commented on a diff in the pull request:
    --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/
    @@ -0,0 +1,41 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package net.nuage.vsp.acs.client;
    +import org.apache.commons.lang3.tuple.Pair;
    +import java.util.Map;
    +public interface NuageVspManagerClient {
    +    Pair<Boolean, String> auditNuageVspCmsId(String nuageVspCmsId, boolean auditOnly)
throws Exception;
    +    String registerNuageVspCmsId() throws Exception;
    +    boolean unregisterNuageVspCmsId(String nuageVspCmsId) throws Exception;
    +    boolean isSupportedApiVersion(String version);
    +    Map<String, Object> getClientDefaults() throws Exception;
    +    boolean syncDomainWithNuageVsp(String domainUuid, String domainName, String domainPath,
boolean add, boolean remove) throws Exception;
    --- End diff --
    This ``throws`` is too broad.  Please enumerate the expected checked exceptions to be

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message