cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...
Date Mon, 12 Oct 2015 17:28:30 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r41780040
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
    @@ -109,12 +163,49 @@
         @Inject
         VpcDao _vpcDao;
         @Inject
    -    NuageVspDao nuageVspDao;
    +    VpcManager _vpcManager;
    +    @Inject
    +    NuageVspDao _nuageVspDao;
    +    @Inject
    +    NuageVspSync _nuageVspSync;
    +    @Inject
    +    DataCenterDao _dataCenterDao;
    +    @Inject
    +    ConfigurationDao _configDao;
    +    @Inject
    +    NetworkModel _ntwkModel;
    +    @Inject
    +    AccountManager _accountMgr;
    +    @Inject
    +    IPAddressDao _ipAddressDao;
    +    @Inject
    +    FirewallRulesDao _firewallDao;
    +    @Inject
    +    VpcServiceMapDao _vpcSrvcDao;
    +    @Inject
    +    AgentManager _agentMgr;
    +    @Inject
    +    private DomainDao _domainDao;
         @Inject
    -    NuageVspSync nuageVspSync;
    +    NetworkOfferingDao _networkOfferingDao;
    +    @Inject
    +    NetworkOfferingServiceMapDao _networkOfferingServiceMapDao;
     
         private ScheduledExecutorService scheduler;
     
    +    @Inject
    +    MessageBus _messageBus;
    +
    +    static {
    +        NUAGE_VSP_PROVIDERS = Sets.newHashSet(Network.Provider.NuageVsp);
    --- End diff --
    
    Use an ``ImmutableSet`` to ensure that the constant cannot be accidentally modified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message