cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...
Date Mon, 12 Oct 2015 07:41:42 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/923#discussion_r41730481
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
    @@ -123,24 +129,29 @@ def add_rule(self, cidr):
                                         " -p %s " % rule['protocol'] +
                                         " -m %s " % rule['protocol'] +
                                         " --dport %s -j RETURN" % rnge])
    +
    +            logging.debug("Current ACL IP direction is ==> %s", self.direction)
                 if self.direction == 'egress':
    -                self.fw.append(["filter", "", " -A FW_OUTBOUND -j FIREWALL_EGRESS_RULES"])
    +                self.fw.append(["filter", "", " -A FW_OUTBOUND -j FW_EGRESS_RULES"])
    --- End diff --
    
    No, I renamed to make it consistent with the default rules, which can be found in the
iptables-router file. That file is installed with cloud early config then afterwards the rules
are replaced.
    
    In addition, the code was also refering to FW_OUTBOUND, not FIREWALL_OUTBOUND. The use
of FW cs FIREWALL doens't look consistent. Now we have only FW.
    
    I hope it's clear. I am at home today... A bit ill. So typing from my mobile
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message