cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdube <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Quota
Date Sun, 11 Oct 2015 11:27:24 GMT
Github user pdube commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/768#discussion_r41709314
  
    --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java
---
    @@ -0,0 +1,147 @@
    +//Licensed to the Apache Software Foundation (ASF) under one
    +//or more contributor license agreements.  See the NOTICE file
    +//distributed with this work for additional information
    +//regarding copyright ownership.  The ASF licenses this file
    +//to you under the Apache License, Version 2.0 (the
    +//"License"); you may not use this file except in compliance
    +//with the License.  You may obtain a copy of the License at
    +//
    +//http://www.apache.org/licenses/LICENSE-2.0
    +//
    +//Unless required by applicable law or agreed to in writing,
    +//software distributed under the License is distributed on an
    +//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +//KIND, either express or implied.  See the License for the
    +//specific language governing permissions and limitations
    +//under the License.
    +package org.apache.cloudstack.api.command;
    +
    +import com.cloud.user.Account;
    +
    +import org.apache.cloudstack.api.APICommand;
    +import org.apache.cloudstack.api.ApiConstants;
    +import org.apache.cloudstack.api.ApiErrorCode;
    +import org.apache.cloudstack.api.BaseCmd;
    +import org.apache.cloudstack.api.Parameter;
    +import org.apache.cloudstack.api.ServerApiException;
    +import org.apache.cloudstack.api.response.DomainResponse;
    +import org.apache.cloudstack.api.response.QuotaCreditsResponse;
    +import org.apache.cloudstack.api.response.QuotaResponseBuilder;
    +import org.apache.cloudstack.context.CallContext;
    +import org.apache.cloudstack.quota.QuotaService;
    +import org.apache.log4j.Logger;
    +
    +import javax.inject.Inject;
    +
    +@APICommand(name = "quotaCredits", responseObject = QuotaCreditsResponse.class, description
= "Add +-credits to an account", since = "4.6.0", requestHasSensitiveInfo = false, responseHasSensitiveInfo
= false)
    +public class QuotaCreditsCmd extends BaseCmd {
    +
    +    @Inject
    +    QuotaResponseBuilder _responseBuilder;
    +
    +    @Inject
    +    QuotaService _quotaService;
    +
    +    public static final Logger s_logger = Logger.getLogger(QuotaStatementCmd.class);
    +
    +    private static final String s_name = "quotacreditsresponse";
    +
    +    @Parameter(name = ApiConstants.ACCOUNT, type = CommandType.STRING, required = true,
description = "Account Id for which quota credits need to be added")
    +    private String accountName;
    +
    +    @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, required = true,
entityType = DomainResponse.class, description = "Domain for which quota credits need to be
added")
    +    private Long domainId;
    +
    +    @Parameter(name = ApiConstants.VALUE, type = CommandType.DOUBLE, required = true,
description = "Value of the credits to be added+, subtracted-")
    +    private Double value;
    +
    +    @Parameter(name = "min_balance", type = CommandType.DOUBLE, required = false, description
= "Minimum balance threshold of the account")
    +    private Double minBalance;
    +
    +    @Parameter(name = "quota_enforce", type = CommandType.BOOLEAN, required = false,
description = "Account for which quota enforce is set to false will not be locked when there
is no credit balance")
    +    private Boolean quotaEnforce;
    +
    +    public Double getMinBalance() {
    +        return minBalance;
    +    }
    +
    +    public void setMinBalance(Double minBalance) {
    +        this.minBalance = minBalance;
    +    }
    +
    +    public Boolean getQuotaEnforce() {
    +        return quotaEnforce;
    +    }
    +
    +    public void setQuotaEnforce(Boolean quotaEnforce) {
    +        this.quotaEnforce = quotaEnforce;
    +    }
    +
    +    public String getAccountName() {
    +        return accountName;
    +    }
    +
    +    public void setAccountName(String accountName) {
    +        this.accountName = accountName;
    +    }
    +
    +    public Long getDomainId() {
    +        return domainId;
    +    }
    +
    +    public void setDomainId(Long domainId) {
    +        this.domainId = domainId;
    +    }
    +
    +    public Double getValue() {
    +        return value;
    +    }
    +
    +    public void setValue(Double value) {
    +        this.value = value;
    +    }
    +
    +    public QuotaCreditsCmd() {
    +        super();
    +    }
    +
    +    @Override
    +    public String getCommandName() {
    +        return s_name;
    +    }
    +
    +    @Override
    +    public void execute() {
    +        Long accountId = null;
    +        Account account = _accountService.getActiveAccountByName(accountName, domainId);
    +        if (account != null) {
    +            accountId = account.getAccountId();
    +        }
    +        if (accountId == null) {
    +            throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "The account does
not exists or has been removed/disabled");
    +        }
    +        if (getValue() == null) {
    +            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Please send a valid
non-empty quota value");
    +        }
    +        if (getQuotaEnforce() != null) {
    +            _quotaService.setLockAccount(accountId, getQuotaEnforce());
    +        }
    +        if (getMinBalance() != null) {
    +            _quotaService.setMinBalance(accountId, getMinBalance());
    +        }
    +        else {
    +            _quotaService.setMinBalance(accountId, 0.2 * getValue());
    +        }
    +
    +        final QuotaCreditsResponse response = _responseBuilder.addQuotaCredits(accountId,
getDomainId(), getValue(), CallContext.current().getCallingUserId());
    +        response.setResponseName(getCommandName());
    +        response.setObjectName("quotacredits");
    +        setResponseObject(response);
    +    }
    +
    +    @Override
    +    public long getEntityOwnerId() {
    +        return Account.ACCOUNT_ID_SYSTEM;
    --- End diff --
    
    Why is the account owner the system in all cases?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message