cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Local cloudstack
Date Sun, 11 Oct 2015 08:07:16 GMT
Github user remibergsma commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/919#discussion_r41707251
  
    --- Diff: tools/marvin/marvin/config/test_data.py ---
    @@ -1617,19 +1617,28 @@
                     "password": "password",
                 },
                 "ldap_account": {
    -                "email": "",
    -                "firstname": "",
    -                "lastname": "",
    -                "username": "",
    -                "password": "",
    +                "email": "hello@world.com",
    +                "firstname": "hello",
    +                "lastname": "world",
    +                "username": "helloworld",
    +                "password": "helloworld",
                 },
                 "ldap_configuration": {
    -                "basedn": "",
    -                "emailAttribute": "",
    -                "userObject": "",
    -                "usernameAttribute": "",
    -                "hostname": "",
    -                "port": "",
    +                "basedn": "CN=Users,DC=hyd-qa,DC=com",
    +                "emailAttribute": "mail",
    +                "userObject": "user",
    +                "usernameAttribute": "sAMAccountName",
    +                "hostname": "10.147.38.163",
    --- End diff --
    
    Hardcoding these values will prevent anyone else than Citrix from running this test. Let's
make sure anyone can run this test instead, or else it will not have the desired effect. Having
a few requirements is fine, but at least make it generic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message