cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <>
Subject [GitHub] cloudstack pull request: Quota
Date Sat, 10 Oct 2015 17:53:49 GMT
Github user bhaisaab commented on a diff in the pull request:
    --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/
    @@ -0,0 +1,88 @@
    +//Licensed to the Apache Software Foundation (ASF) under one
    +//or more contributor license agreements.  See the NOTICE file
    +//distributed with this work for additional information
    +//regarding copyright ownership.  The ASF licenses this file
    +//to you under the Apache License, Version 2.0 (the
    +//"License"); you may not use this file except in compliance
    +//with the License.  You may obtain a copy of the License at
    +//Unless required by applicable law or agreed to in writing,
    +//software distributed under the License is distributed on an
    +//KIND, either express or implied.  See the License for the
    +//specific language governing permissions and limitations
    +//under the License.
    +package org.apache.cloudstack.quota.dao;
    +import java.util.ArrayList;
    +import java.util.Date;
    +import java.util.List;
    +import javax.ejb.Local;
    +import javax.inject.Inject;
    +import org.apache.log4j.Logger;
    +import org.springframework.stereotype.Component;
    +import org.apache.cloudstack.quota.vo.QuotaBalanceVO;
    +import org.apache.cloudstack.quota.vo.QuotaCreditsVO;
    +@Local(value = { QuotaCreditsDao.class })
    +public class QuotaCreditsDaoImpl extends GenericDaoBase<QuotaCreditsVO, Long> implements
QuotaCreditsDao {
    +    private static final Logger s_logger = Logger.getLogger(QuotaCreditsDaoImpl.class.getName());
    +    @Inject
    +    QuotaBalanceDao _quotaBalanceDao;
    +    @SuppressWarnings("deprecation")
    +    @Override
    +    public List<QuotaCreditsVO> findCredits(final long accountId, final long domainId,
final Date startDate, final Date endDate) {
    +        final short opendb = TransactionLegacy.currentTxn().getDatabaseId();
    +        List<QuotaCreditsVO> qc = new ArrayList<>();
    +        try {
    +  ;
    +            Filter filter = new Filter(QuotaCreditsVO.class, "updatedOn", true, 0L, Long.MAX_VALUE);
    +            SearchCriteria<QuotaCreditsVO> sc = createSearchCriteria();
    +            sc.addAnd("accountId", SearchCriteria.Op.EQ, accountId);
    +            sc.addAnd("domainId", SearchCriteria.Op.EQ, domainId);
    +            if ((startDate != null) && (endDate != null) && startDate.before(endDate))
    +                sc.addAnd("updatedOn", SearchCriteria.Op.BETWEEN, startDate, endDate);
    +            } else {
    +                return new ArrayList<QuotaCreditsVO>();
    +            }
    +            qc = search(sc, filter);
    +        } catch (Exception e) {
    +            s_logger.error("QuotaCreditsDaoImpl::findCredits() failed due to: " + e.getMessage());
    --- End diff --
    We don't want the stack trace to end up in the API response, so we are logging it but
throwing a general descriptive error.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message