cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From terbolous <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Dockerfile part2
Date Mon, 05 Oct 2015 08:29:50 GMT
Github user terbolous commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/910#discussion_r41120279
  
    --- Diff: tools/docker/Dockerfile.centos6 ---
    @@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2" Version="4.6.0"
     ENV PKG_URL=http://jenkins.buildacloud.org/job/package-rhel63-master/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64
     
     # install CloudStack
    -RUN yum install -y \
    +RUN yum install -y nc wget \
         ${PKG_URL}/cloudstack-common-4.6.0-SNAPSHOT.el6.x86_64.rpm \
         ${PKG_URL}/cloudstack-management-4.6.0-SNAPSHOT.el6.x86_64.rpm
     
     RUN cd /etc/cloudstack/management; \
         ln -s tomcat6-nonssl.conf tomcat6.conf; \
         ln -s server-nonssl.xml server.xml; \
    -    ln -s log4j-cloud.xml log4j.xml
    +    ln -s log4j-cloud.xml log4j.xml; \
    +    cd /usr/share/cloudstack-common/scripts/vm/hypervisor/xenserver; \
    +    wget http://download.cloud.com.s3.amazonaws.com/tools/vhd-util
    --- End diff --
    
    I wouldn't say assuming, more like facilitating for a XS host. We know that vhd-util is
a requirement for XS, imho it is better to bundle it than adding a manual "oh, remember to
install vhd-util first" note.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message