cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8915 - Cannot SSH into VMs dep...
Date Fri, 02 Oct 2015 20:56:15 GMT
Github user remibergsma commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/908#discussion_r41066665
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
    @@ -96,7 +96,8 @@ def _redundant_on(self):
                     d = s.replace(".templ", "")
                 CsHelper.copy_if_needed(
                     "%s/%s" % (self.CS_TEMPLATES_DIR, s), "%s/%s" % (self.CS_ROUTER_DIR,
d))
    -        CsHelper.copy(
    --- End diff --
    
    This was recently changed from copy_if_needed to copy in PR 763 / 692 to solve CLOUDSTACK-8725.
Are we sure we want to reverse that? Tests are green but there may not be a test for this?
Please double check.
    
    Discussion: https://github.com/apache/cloudstack/pull/692
    Jira: https://issues.apache.org/jira/browse/CLOUDSTACK-8725
    PR: https://github.com/apache/cloudstack/pull/763/files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message