cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From borisroman <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8915 - Cannot SSH into VMs dep...
Date Fri, 02 Oct 2015 16:30:31 GMT
Github user borisroman commented on the pull request:

    https://github.com/apache/cloudstack/pull/908#issuecomment-145079681
  
    @wilderrodrigues I've ran the same tests as you proposed. On Centos KVM hosts. Resulting
in success besides the same exceptions. So that's :+1:  LGTM
    
    Regarding the exceptions, see [1] here the network is created. But in the test the network
was never removed, so cleanup would definitely fail, [2].
    
    These integration tests should be rewritten so the network is removed inside the test,
this could be done now, or in a separate PR as it doesn't alter system behavior.
    
    [1]  https://github.com/apache/cloudstack/blob/237e0e4611dd3d0ae56a8c0557dba93e7fbd3440/test/integration/component/test_routers_iptables_default_policy.py#L290
    [2] https://github.com/apache/cloudstack/blob/a0f8f56a5dd3a323a72eb2a145d64cb1b5abea49/server/src/com/cloud/configuration/ConfigurationManagerImpl.java#L4635


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message