cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8808: Successfully registered ...
Date Thu, 01 Oct 2015 06:07:50 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/901#discussion_r40881668
  
    --- Diff: core/src/com/cloud/storage/template/QCOW2Processor.java ---
    @@ -75,6 +76,16 @@ public FormatInfo process(String templatePath, ImageFormat format,
String templa
     
         @Override
         public long getVirtualSize(File file) throws IOException {
    +        try {
    +            long size = getTemplateVirtualSize(file);
    --- End diff --
    
    The utils one should be a recent implementation. I wonder why the author hasnt done cleanup
and left two implementation of the same. I will take a look at the code later and see if it
can be reused here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message