Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D30E717790 for ; Tue, 29 Sep 2015 12:28:53 +0000 (UTC) Received: (qmail 71365 invoked by uid 500); 29 Sep 2015 12:28:53 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 71258 invoked by uid 500); 29 Sep 2015 12:28:53 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 70865 invoked by uid 99); 29 Sep 2015 12:28:53 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2015 12:28:53 +0000 Received: from mail-io0-f174.google.com (mail-io0-f174.google.com [209.85.223.174]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 0CB4F1A0040 for ; Tue, 29 Sep 2015 12:28:53 +0000 (UTC) Received: by ioiz6 with SMTP id z6so8236402ioi.2 for ; Tue, 29 Sep 2015 05:28:52 -0700 (PDT) X-Gm-Message-State: ALoCoQnWPMKuOtQS0LLXrOZtMcZhhnmDUXtyPdEY5ZzLA7eTO8qXRVF0A8ckqeTDLLOxFnfF72tM MIME-Version: 1.0 X-Received: by 10.107.13.196 with SMTP id 187mr24040947ion.58.1443529732487; Tue, 29 Sep 2015 05:28:52 -0700 (PDT) Received: by 10.50.248.174 with HTTP; Tue, 29 Sep 2015 05:28:52 -0700 (PDT) In-Reply-To: References: Date: Tue, 29 Sep 2015 08:28:52 -0400 Message-ID: Subject: Re: [GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam... From: Pierre-Luc Dion To: "dev@cloudstack.apache.org" Content-Type: multipart/alternative; boundary=001a113fee6aed972c0520e1f4ec --001a113fee6aed972c0520e1f4ec Content-Type: text/plain; charset=UTF-8 Hi, Can someone LGTM this PR ? or we don't need the 2 LGTM as it's not on master? This fix the build of cloudstack simulator docker container of 4.5.x Thanks On Sun, Sep 27, 2015 at 8:57 PM, pdion891 wrote: > GitHub user pdion891 opened a pull request: > > https://github.com/apache/cloudstack/pull/893 > > Fix dockerbuild because hardcoded filename for marvin > > This fix docker simulator build of latest 4.5.x. > > This PR only go in 4.5 branch. > > Thanks > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/pdion891/cloudstack 4.5-dockerfile > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/cloudstack/pull/893.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #893 > > ---- > commit 04ffeb8f350d7858be52bf9fbc5506b01fdf31a2 > Author: Pierre-Luc Dion > Date: 2015-09-28T00:53:34Z > > Fix dockerbuild because hardcoded filename for marvin > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastructure@apache.org or file a JIRA ticket > with INFRA. > --- > --001a113fee6aed972c0520e1f4ec--