Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 46E7217A19 for ; Mon, 28 Sep 2015 12:35:41 +0000 (UTC) Received: (qmail 72506 invoked by uid 500); 28 Sep 2015 12:35:34 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 72445 invoked by uid 500); 28 Sep 2015 12:35:34 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 72433 invoked by uid 99); 28 Sep 2015 12:35:34 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Sep 2015 12:35:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E5353C69B5 for ; Mon, 28 Sep 2015 12:35:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.099 X-Spam-Level: X-Spam-Status: No, score=-0.099 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MnsDQ2A904wt for ; Mon, 28 Sep 2015 12:35:21 +0000 (UTC) Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 6A3DD20E5C for ; Mon, 28 Sep 2015 12:35:20 +0000 (UTC) Received: by wiclk2 with SMTP id lk2so99173794wic.1 for ; Mon, 28 Sep 2015 05:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to; bh=DI/aK4R9iYZ6scCl7pTbi/FzgHMyPinF/mYdQnmoNh8=; b=GmMWl7SiXHfb2vF6nwUusfc1eyN8thE1IkpveWQPfgDHnpBoEcBPGeyy8c9HpnpOYI 4j/0uNpp1MF/TJKI+tETP3YrMhHAJ11JPga+YQbXKY3jr1r+PPsobI4IMIyn5jP83wj2 UvvPcJhcyz0yFbn5DZ9cqbC6rU+YaY8DryyhAC+pd4UQQkGudCYZa8UBWZy2RpnJ2cgc lVt3wXwuYsdJEAFFF6rg6Y/pA7ilQ4BTEzvLoHV8pSFNm4lR4wWZtxFFRNmhDm9n3eTt qatf9QyZV8qv8PF9ru5EmwySRZ+arwZ/hyubQMiOV9ACTaieS/m1P8S9AWoYlIqvNJyA 4OtQ== X-Received: by 10.180.186.10 with SMTP id fg10mr18806800wic.30.1443443720070; Mon, 28 Sep 2015 05:35:20 -0700 (PDT) Received: from [10.0.0.105] (229.194.193.178.dynamic.wline.res.cust.swisscom.ch. [178.193.194.229]) by smtp.gmail.com with ESMTPSA id fv13sm18120002wic.7.2015.09.28.05.35.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Sep 2015 05:35:18 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: Blameless post mortem From: Sebastien Goasguen In-Reply-To: Date: Mon, 28 Sep 2015 14:35:16 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <5BC88E8D-A9CA-4ECC-9367-128DFCF1D560@citrix.com> <2811910E-7755-4F88-9C17-6FBC8D56AB77@schubergphilis.com> <1C0478C5-C247-488B-A38E-4EA8C1E0BB62@citrix.com> <05793625-224F-4CBB-B669-780F7960DB12@gmail.com> <2EDC1FA8-DDDD-448D-A531-0833F492B772@schubergphilis.com> To: dev@cloudstack.apache.org X-Mailer: Apple Mail (2.2102) Folks let=92s chill for a second here, Let=92s be pragmatic: First, - Master got unstable with lots of issues related to the VPC - Issues were fixed=20 - Let=92s go back to blockers, fix and release 4.6 Second, - We have a postmortem from Remi. - Let=92s talk it out, first with the folks that will be in Dublin or in = a separate thread. - Then live with a planned on-line hangout of sorts - I believe that for now our focus should be on 4.6 Third, - We are trying a new process for 4.6. Which is to stabilize master and = release from there - This is a big change compared to developing on master which is what we = used to do. - We are embracing github PR - PR are the place to ask for questions on code, ask for more tests = etc.. - We know we need more tests and more docs, we have known that forever - The VPC refactor started a long time back, maybe I am confused but it = seems that any VPC related add-on will have to work with this refactor. So please, no name calling, this is against ASF policy, we have thick = skins but let=92s keep it cordial and get our eyes back on the ball ie. What=92s the latest BVT result ? What are the blockers etc ? -Sebastien > On Sep 28, 2015, at 2:19 PM, Bharat Kumar = wrote: >=20 > Dude, >=20 > There was nothing friendly about the postmortem you did, It was only = partial, we should do a complete postmortem and then draw conclusions. >=20 > I think the post-mortems like this are of no use if we do not do them = completely. >=20 > Regards, > Bharat. >=20 > On 28-Sep-2015, at 5:39 pm, Remi Bergsma = wrote: >=20 >> Dude, this is the final friendly email about his. All points have = been made in previous mails. This has nothing to do with =91blameless=92 = and =91learning=92 anymore. >>=20 >> Read Seb=92s mail. We will move on now. >>=20 >>=20 >> Regards, Remi >>=20 >>=20 >>=20 >> On 28/09/15 13:54, "Bharat Kumar" wrote: >>=20 >>> Hi Remi, >>>=20 >>> Whatever ever we think we have discovered are all well known best = practices while developing code in community.=20 >>> I agree that tests need to be run on a new PR, but i wonder why was = this ignored when merging the VR refactor code. Perhaps we will uncover = some more issues if we investigate this. I believe=20 >>> one of the reasons for this is the complexity and incomplete nature = of the vr refactor change and failing to identify the areas which got = effected. If we had a good documentation i think we cloud have = understood the areas that were getting=20 >>> impacted early on, areas like the vpn , iptables, isolated networks = rvr etc and run the relevant tests. The documentation will also help = us focus on these areas while reviewing and fixing subsequent issues. = Currently no one knows the areas that got effected=20 >>> due to the vr refactor change, we are seeing issues all over the = code. I think this is a bigger problem than what we have discussed so = far. >>>=20 >>> I think presently we should stop fixing all the vr refactoring bugs = until we come up with a proper document describing the VR refactoring = changes. >>>=20 >>> I am not suggesting that we should revert the vr refactor code, I am = willing to work on this and fix the issues, I am only asking if we can = get some documentation. >>>=20 >>>=20 >>> Regards, >>> Bharat. >>>=20 >>> On 28-Sep-2015, at 4:59 pm, Sebastien Goasguen = wrote: >>>=20 >>>>=20 >>>>> On Sep 28, 2015, at 1:14 PM, Remi Bergsma = wrote: >>>>>=20 >>>>> Hi Bharat, >>>>>=20 >>>>>=20 >>>>> There is only one way to prove a feature works: with tests. That=92s= why I say actually _running_ the tests we have today on any new PR, is = the most important thing. Having no documentation is a problem, I agree, = but it is not more important IMHO. If we had the documentation, we still = would have issues if nobody runs the tests and verifies pull requests. = Documentation that is perfect does not automatically lead to perfect = implementation. So we need tests to verify. >>>>>=20 >>>>> If we don=92t agree that is also fine. We need to do both anyway = and I think we do agree on that. >>>>>=20 >>>>=20 >>>> Also we need to move forward. We should have a live chat once 4.6 = is out to discuss all issues/problems and iron out the process. >>>>=20 >>>> But reverting the VR refactor is not going to happen. There was = ample discussions on the PR when it was submitted, there was time to = review and raise concerns at that time. It went through quite a few = reviews, tests etc=85Maybe the documentation is not good, but the time = to raise this concern I am afraid was six months ago. We can learn from = it, but we are not going to revert it, this would not go cleanly as = David mentioned. >>>>=20 >>>> So let=92s get back to blockers for 4.6, are there still VR related = issues with master ? >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>> Regards, >>>>> Remi >>>>>=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>>> On 28/09/15 12:15, "Bharat Kumar" wrote: >>>>>=20 >>>>>> Hi Remi, >>>>>>=20 >>>>>> i do not agree with =93There is no bigger problem=94 part of = your reply. so I had to repeat myself to make it more clear, Not because = i am not aware of what this thread is supposed to do. >>>>>>=20 >>>>>> Regards, >>>>>> Bharat. >>>>>>=20 >>>>>> On 28-Sep-2015, at 2:51 pm, Remi Bergsma = wrote: >>>>>>=20 >>>>>>> Hi Bharat, >>>>>>>=20 >>>>>>> I understand your frustrations but we already agreed on this so = no need to repeat. This thread is supposed to list some improvements and = learn from it. Your point has been taken so let=92s move on. >>>>>>>=20 >>>>>>> We need documentation first, then do a change after which all = tests should pass. Even better is we write (missing) tests before = changing stuff so you know they pass before and after the fact.=20 >>>>>>>=20 >>>>>>> When doing reviews, feel free to ask for design documentation if = you feel it is needed. >>>>>>>=20 >>>>>>> Regards, Remi >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>> On 28/09/15 11:02, "Bharat Kumar" = wrote: >>>>>>>=20 >>>>>>>> Hi Remi, >>>>>>>>=20 >>>>>>>> I never intended to say that we should not run tests, but even = before tests we should have proper documentation. My concern was if a = major change is being introduced it should be properly documented. All = the issues which we are trying to fix are majorly due to VR refactor. If = there was a proper documentation for this we could >>>>>>>> have fixed this in a better way. Even to add tests we need to = understand how a particular thing works and what data dose it expect. I = think while fixing the python based code changes this is where most of = the people are facing issues. A proper documentation will help in = understanding these in a better way. >>>>>>>>=20 >>>>>>>> Thanks, >>>>>>>> Bharat. >>>>>>>>=20 >>>>>>>> On 28-Sep-2015, at 1:57 pm, Remi Bergsma = wrote: >>>>>>>>=20 >>>>>>>>> Hi Bharat, >>>>>>>>>=20 >>>>>>>>> There is no bigger problem. We should always run the tests and = if we find a case that isn=92t currently covered by the tests we should = simply add tests for it. There=92s no way we=92ll get a stable master = without them. The fact that they may not cover everything, is no reason = to not rely on them. If a feature is not important enough to write a = test for, then the feature is probably not important anyway. And if it = is, then add a test :-) >>>>>>>>>=20 >>>>>>>>> I do agree on the design documentation requirement for any = (major?) change. I found some design documentations on the subject you = mention, but it should have been more detailed.=20 >>>>>>>>>=20 >>>>>>>>> Regards, >>>>>>>>> Remi >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>> On 28/09/15 09:58, "Bharat Kumar" = wrote: >>>>>>>>>=20 >>>>>>>>>> Hi Remi, >>>>>>>>>>=20 >>>>>>>>>> Thank you for the Blame less postmortem.=20 >>>>>>>>>>=20 >>>>>>>>>> I think there is a bigger problem here than just the review = process and running tests. Even if we run the tests we cannot be sure = that every thing will work as intended. The tests will only give some = level of confidence. The tests may not cover all the use cases. >>>>>>>>>>=20 >>>>>>>>>> I think the problem here is that the way major changes to the = code base are dealt with. For example, VR refactoring was done without = discussing the design implications and the amount of changes it would = bring in. I could not find any design document. The vr refactor changed = a lot of code and the way VR used to work and in my opinion it was = incomplete-vpn, isolated networks, basic networks, iptable rules and rvr = in isolated case etc were not implemented. Most of us are still in the = process of understanding this. Even before reaching this state we had to = spend a lot of time fixing issues mentioned in the thread = [Blocker/Critical] VR related Issues. =20 >>>>>>>>>>=20 >>>>>>>>>> When a change of this magnitude is being made, we should call = out all the changes and document them properly. This will help people to = create better fixes. Currently when we attempt to fix the isolated vr = case it is effecting the vpc and vice versa. for example pr 738 fixed it = for vpc networks but broke it for isolated case. I believe it is not too = late to at least start documenting the changes now. >>>>>>>>>>=20 >>>>>>>>>> Thanks, >>>>>>>>>> Bharat. >>>>>>>>>>=20 >>>>>>>>>> On 28-Sep-2015, at 10:52 am, Sanjeev N = wrote: >>>>>>>>>>=20 >>>>>>>>>>> I have a concern here. Some of us are actively involved in = reviewing the >>>>>>>>>>> PRs related to marvin tests(Enhancing existing tests/Adding = new tests). If >>>>>>>>>>> we have to test a PR it requires an environment to be = created with actual >>>>>>>>>>> resources and this is going to take lot of time. Some of the = tests can run >>>>>>>>>>> on simulator but most of the tests require real hardware to = test. PR >>>>>>>>>>> submitter is already testing and submitting the test results = along with the >>>>>>>>>>> PR. So is it require to test these PRs by reviewers? >>>>>>>>>>>=20 >>>>>>>>>>> On Sat, Sep 26, 2015 at 1:49 PM, sebgoa = wrote: >>>>>>>>>>>=20 >>>>>>>>>>>> Remi, thanks for the detailed post-mortem, it's a good read = and great >>>>>>>>>>>> learning. >>>>>>>>>>>> I hope everyone reads it. >>>>>>>>>>>>=20 >>>>>>>>>>>> The one thing to emphasize is that we now have a very = visible way to get >>>>>>>>>>>> code into master, we have folks investing time to provide = review (great), >>>>>>>>>>>> we need the submitters to make due diligence and answer all = comments in the >>>>>>>>>>>> reviews. >>>>>>>>>>>>=20 >>>>>>>>>>>> In another project i work on, nothing can be added to the = code without >>>>>>>>>>>> unit tests. I think we could go down the route of asking = for new >>>>>>>>>>>> integration tests and unit tests for anything. If not, the = PR does not get >>>>>>>>>>>> merged. But let's digest your post-mortem and we can = discuss after 4.6.0. >>>>>>>>>>>>=20 >>>>>>>>>>>> I see that you reverted one commit that was not made by = you, that's great. >>>>>>>>>>>>=20 >>>>>>>>>>>> Let's focus on the blockers now, everything else can wait. >>>>>>>>>>>>=20 >>>>>>>>>>>> The big bonus of doing what we are doing is that once 4.6.0 = is out, we can >>>>>>>>>>>> merge PRs again (assuming they are properly rebased and = tested) and we can >>>>>>>>>>>> release 4.6.1 really quickly after. >>>>>>>>>>>>=20 >>>>>>>>>>>> -sebastien >>>>>>>>>>>>=20 >>>>>>>>>>>> On Sep 25, 2015, at 9:51 PM, Remi Bergsma = >>>>>>>>>>>> wrote: >>>>>>>>>>>>=20 >>>>>>>>>>>>> Hi all, >>>>>>>>>>>>>=20 >>>>>>>>>>>>> This mail is intended to be blameless. We need to learn = something from >>>>>>>>>>>> it. That's why I left out who exactly did what because it=92s= not relevant. >>>>>>>>>>>> There are multiple examples but it's about the why. Let's = learn from this >>>>>>>>>>>> without blaming anyone. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> We know we need automated testing. We have integration = tests, but we are >>>>>>>>>>>> unable to run all of them on any Pull Request we receive. = If we would have >>>>>>>>>>>> that in place, it'd be much easier to spot errors, = regression and so on. >>>>>>>>>>>> It'd also be more rewarding to write more tests. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Unfortunately we're not there yet. So, we need to do = something else >>>>>>>>>>>> instead until we get there. If we do nothing, we know we = have many issues >>>>>>>>>>>> because a master that breaks on a regular basis is the most = frustrating >>>>>>>>>>>> things. We said we'd use Pull Requests with at least two = humans to review >>>>>>>>>>>> and give their OK for a Pull Request. In the form of LGTM: = Looks Good To >>>>>>>>>>>> Me. Ok, so the LGTMs are there because we have no automated = testing. Keep >>>>>>>>>>>> that in mind. You are supposed to replace automated testing = until it's >>>>>>>>>>>> there. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Since we do this, master got a lot more stable. But every = now and then >>>>>>>>>>>> we still have issues. Let's look at how we do manual = reviews. Again, this >>>>>>>>>>>> is not to blame anyone. It's to open our eyes and make us = realise what >>>>>>>>>>>> we're doing and what results we get out of that. >>>>>>>>>>>>>=20 >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Example Pull Request #784: >>>>>>>>>>>>> Title: CLOUDSTACK-8799 fixed the default routes >>>>>>>>>>>>>=20 >>>>>>>>>>>>> That's nice, it has a Jira id and a short description (as = it should be). >>>>>>>>>>>>>=20 >>>>>>>>>>>>> The first person comes along and makes a comment: >>>>>>>>>>>>> "There was also an issue with VPC VRs" ... "Have you seen = this issue? >>>>>>>>>>>> Does your change affects the VPC VR (single/redundant)?" >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Actually a good question. Unfortunaly there comes no = answer. After a >>>>>>>>>>>> reminder, it was promised to do tests against VPC networks. = Great! >>>>>>>>>>>>>=20 >>>>>>>>>>>>> The Jenkins builds both succeed and also Travis is green. = But how much >>>>>>>>>>>> value does this have? They have the impression to do = automated testing, and >>>>>>>>>>>> although you could argue they do, it's far from complete. = If it breaks, you >>>>>>>>>>>> know you have an issue. But it doesn=92t work the other way = around. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Back to our example PR. In the mean time, another commit = gets pushed to >>>>>>>>>>>> it: "CLOUDSTACK-8799 fixed for vpc networks." But if you = look at the Jira >>>>>>>>>>>> issue, you see it is about redundant virtual routers. The = non-VPC ones. So >>>>>>>>>>>> this is vague at best. But a reviewer gives a LGTM because = the person could >>>>>>>>>>>> create a VPC. That doesn't have anything to do with the = problem being fixed >>>>>>>>>>>> in this PR nor with the comments made earlier. But, at = least the person >>>>>>>>>>>> said what he did and we should all do that. What nobody = knew back then, was >>>>>>>>>>>> that this broke the default route on VPCs. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Then something strange happens: the two commits from the = PR end up on >>>>>>>>>>>> master as direct commits. With just one LGTM and no = verification from the >>>>>>>>>>>> person commenting about the linked issue. This happened on = Friday September >>>>>>>>>>>> 11th. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> That day 21 commits came in, from 7 Pull Request and = unfortunately also >>>>>>>>>>>> from some direct commits. We noticed the direct commits and = notified the >>>>>>>>>>>> list = (http://cloudstack.markmail.org/message/srmszloyipkxml36). As a lot >>>>>>>>>>>> came in at the same time, it was decided not to revert = them. Looking back, >>>>>>>>>>>> we should have done it. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> =46rom this point on, VPCs were broken as they wouldn't = get a default >>>>>>>>>>>> route. So, no public internet access from VMs in VPC tiers, = no VPNs >>>>>>>>>>>> working, etc. This was mentioned to the list on Thursday = September 15th, >>>>>>>>>>>> after some chats and debugging going on over the weekend ( >>>>>>>>>>>> http://cloudstack.markmail.org/message/73ulpu4p75ex24tc) >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Here we are, master is broken functionality wise and new = Pull Requests >>>>>>>>>>>> come in to fix blockers. But we cannot ever test their = proper working, >>>>>>>>>>>> because VPCs are broken in master and so also in the PRs = branched off of >>>>>>>>>>>> it. With or without change in the PR. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> It starts to escalate as the days go by. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> I=92ll leave out the bit on how this frustrated people. = Although it=92s good >>>>>>>>>>>> to know we do not want to be in this situation. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Eventually Wilder and I spent an evening and a day working = on a branch >>>>>>>>>>>> where we loaded 7 PRs on top of each other (all VR related) = only to find >>>>>>>>>>>> the VPC is still broken. It allowed us to zoom in and find = the default >>>>>>>>>>>> route was missing again. We said it worked 3 weeks before, = because the same >>>>>>>>>>>> tests that succeeded then, now were broken. We had already = fixed this in PR >>>>>>>>>>>> #738 on August 25 so were sure about it. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> After some digging we could trace it back to Pull Request = #784. Imagine >>>>>>>>>>>> the feeling seeing your own comment there mentioning the = previous issue on >>>>>>>>>>>> the default gateways. Fair to say our human review process = clearly failed >>>>>>>>>>>> here. Many many hours were spent on this problem over the = past two weeks. >>>>>>>>>>>> Could we have prevented this from happening? I think so, = yes. >>>>>>>>>>>>>=20 >>>>>>>>>>>>>=20 >>>>>>>>>>>>> This example clearly shows why: >>>>>>>>>>>>>=20 >>>>>>>>>>>>> - we should use Pull Requests >>>>>>>>>>>>> It made the change visible: Great! >>>>>>>>>>>>>=20 >>>>>>>>>>>>> - we do reviews and ask for feedback >>>>>>>>>>>>> We got feedback and questions: Also great! >>>>>>>>>>>>>=20 >>>>>>>>>>>>> - we should always respond to feedback and verify it is = resolved, before >>>>>>>>>>>> merging >>>>>>>>>>>>> We need to improve here. Even with two reviewers that say = LGTM, we >>>>>>>>>>>> should still address any feedback before merging. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> - we should have two humans doing a review >>>>>>>>>>>>> We need to improve here as well. Not one reviewer, we need = two. Really. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> - we need to document why we say LGTM. >>>>>>>>>>>>> Another improvement. It=92s nice to say LGTM, but a review = of only 4 >>>>>>>>>>>> characters and nothing more is useless. We need to know = what was tested and >>>>>>>>>>>> how. Test results, screen shots or anything that shows = what's been >>>>>>>>>>>> verified. If you only reviewed the code, also fine but at = least say that. >>>>>>>>>>>> Then the next reviewer should do another type of review to = get the comlete >>>>>>>>>>>> picture. Remember you're replacing automated testing! >>>>>>>>>>>>>=20 >>>>>>>>>>>>> - we should always merge Pull Requests >>>>>>>>>>>>> We made it easy, merging is the de facto standard, and it = has even more >>>>>>>>>>>> benefits. You can trace commits back to their Pull Request = (and find all >>>>>>>>>>>> comments and discussion there: saves time, trust me). It = also allows for >>>>>>>>>>>> easier reverting of a Pull Request. We=92ll see even more = benefits once 4.7 >>>>>>>>>>>> is there. Although the intentions to merge the Pull Request = were there, it >>>>>>>>>>>> still didn't happen. We should always check before we push. = As a committer >>>>>>>>>>>> we just need to be sure. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> - we need automated testing! >>>>>>>>>>>>> The sooner the better. It=92s all about the missing = automated testing. >>>>>>>>>>>> After 4.6, we all need to focus on this. Saves a lot of = time. And >>>>>>>>>>>> frustrations. >>>>>>>>>>>>>=20 >>>>>>>>>>>>>=20 >>>>>>>>>>>>>=20 >>>>>>>>>>>>> We're doing final testing on PR #887 and will merge it = soon. =46rom that >>>>>>>>>>>> point on we can look into new issues. Be aware that any PR = out there that >>>>>>>>>>>> was created after September 10 needs to be rebased with = current master >>>>>>>>>>>> (when #887 is merged). Without that, no serious testing can = be done. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Let's be careful what to land on master. I'll only be = merging Pull >>>>>>>>>>>> Requests that have had proper reviews with information on = what was tested. >>>>>>>>>>>> At least one reviewer needs to actually verify it works = (and show the rest >>>>>>>>>>>> of us). We simply cannot assume it will work. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> If we do this, I think we can start resolving the = remaining blockers >>>>>>>>>>>> one-by-one and go into the first RC round. Please help out = where you can so >>>>>>>>>>>> we can make this a success together. Thanks! >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Looking forward to the day we have our automated testing = in place ;-) >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Regards, >>>>>>>>>>>>> Remi >>>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>=20 >>>>>>>>=20 >>>>>>=20 >>>>=20 >>>=20 >=20