Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-885-cloudstack@git.apache.org>
In-Reply-To: <git-pr-885-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state
 is up...
Content-Type: text/plain
Message-Id: <20150930090543.04CA1DFF70@git1-us-west.apache.org>
Date: Wed, 30 Sep 2015 09:05:43 +0000 (UTC)

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/885#discussion_r40772428
  
    --- Diff: engine/schema/src/com/cloud/vm/dao/VMInstanceDaoImpl.java ---
    @@ -805,6 +805,12 @@ public Boolean doInTransaction(TransactionStatus status) {
         }
     
         @Override
    +    public boolean isPowerStateUpToDate(final long instanceId) {
    +        VMInstanceVO instance = findById(instanceId);
    +        return instance.getPowerStateUpdateCount() < MAX_CONSECUTIVE_SAME_STATE_UPDATE_COUNT;
    --- End diff --
    
    Are we sure instance in not null at this point?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---