Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5105176E5 for ; Sat, 19 Sep 2015 22:51:58 +0000 (UTC) Received: (qmail 39443 invoked by uid 500); 19 Sep 2015 22:51:58 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 39388 invoked by uid 500); 19 Sep 2015 22:51:58 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 39377 invoked by uid 99); 19 Sep 2015 22:51:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Sep 2015 22:51:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7740EE0063; Sat, 19 Sep 2015 22:51:57 +0000 (UTC) From: rafaelweingartner To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Removed the empty class 'com.cloud.deploy... Content-Type: text/plain Message-Id: <20150919225157.7740EE0063@git1-us-west.apache.org> Date: Sat, 19 Sep 2015 22:51:57 +0000 (UTC) Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/856#issuecomment-141712362 @pedro-martins that is good that you removed and unused method in com.cloud.deploy.DeploymentPlanner, however you forgot to remove all of the implementations of classes that implement it. BareMetalPlanner is one of the classes that you forgot to fix, there are others --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---