Return-Path: 
 <dev-return-80830-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 668821796F
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Fri, 18 Sep 2015 22:34:10 +0000 (UTC)
Received: (qmail 69436 invoked by uid 500); 18 Sep 2015 22:34:10 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 69378 invoked by uid 500); 18 Sep 2015 22:34:10 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 69366 invoked by uid 99); 18 Sep 2015 22:34:09 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Sep 2015 22:34:09 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id A1980E042F; Fri, 18 Sep 2015 22:34:09 +0000 (UTC)
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-801-cloudstack@git.apache.org>
In-Reply-To: <git-pr-801-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP
 plugin...
Content-Type: text/plain
Message-Id: <20150918223409.A1980E042F@git1-us-west.apache.org>
Date: Fri, 18 Sep 2015 22:34:09 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39907736
  
    --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java ---
    @@ -24,12 +24,17 @@
     
     public interface NuageVspElementClient {
     
    -    public void applyStaticNats(String networkDomainUuid, String vpcOrSubnetUuid, boolean isL3Network, List<Map<String, Object>> staticNatDetails) throws Exception;
    +    public boolean implement(long networkId, String networkDomainUuid, String networkUuid, String networkName, String vpcOrSubnetUuid, boolean isL2Network, boolean isL3Network,
    +                             boolean isVpc, boolean isShared, String domainTemplateName, boolean isFirewallServiceSupported, List<String> dnsServers, List<Map<String, Object>> ingressFirewallRules,
    +                             List<Map<String, Object>> egressFirewallRules, List<String> acsFipUuid, boolean egressDefaultPolicy) throws Exception;
     
    -    public void applyAclRules(String networkUuid, String networkDomainUuid, String vpcOrSubnetUuid, boolean isL3Network, List<Map<String, Object>> aclRules, boolean isVpc, long networkId)
    -            throws Exception;
    +    public void applyStaticNats(String networkDomainUuid, String networkUuid, String vpcOrSubnetUuid, boolean isL3Network, boolean isVpc,
    +                                List<Map<String, Object>> staticNatDetails) throws Exception;
     
    -    public void shutDownVpc(String domainUuid, String vpcUuid) throws Exception;
    +    public void applyAclRules(boolean isNetworkAcl, String networkUuid, String networkDomainUuid, String vpcOrSubnetUuid, String networkName, boolean isL2Network,
    +                              List<Map<String, Object>> rules, long networkId, boolean egressDefaultPolicy, Boolean isAcsIngressAcl, boolean networkReset, String domainTemplateName) throws Exception;
    +
    +    public void shutdownVpc(String domainUuid, String vpcUuid, String domainTemplateName) throws Exception;
    --- End diff --
    
    Why is Exception declared in the throws instead of the list of expected checked exceptions on all of these methods?
    
    Also, ``public`` modifiers on ``public interface`` declarations are extraneous. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---