Return-Path: 
 <dev-return-80730-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 56DF218FB5
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Fri, 18 Sep 2015 20:10:49 +0000 (UTC)
Received: (qmail 40706 invoked by uid 500); 18 Sep 2015 20:10:48 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 40651 invoked by uid 500); 18 Sep 2015 20:10:48 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 40634 invoked by uid 99); 18 Sep 2015 20:10:48 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Sep 2015 20:10:48 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 7D9CBE0441; Fri, 18 Sep 2015 20:10:48 +0000 (UTC)
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-801-cloudstack@git.apache.org>
In-Reply-To: <git-pr-801-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP
 plugin...
Content-Type: text/plain
Message-Id: <20150918201048.7D9CBE0441@git1-us-west.apache.org>
Date: Fri, 18 Sep 2015 20:10:48 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39895682
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java ---
    @@ -33,16 +34,23 @@
         String _networkName;
         String _networkCidr;
         String _networkGateway;
    +    Long _networkAclId;
    +    List<String> _dnsServers;
    +    List<String> _gatewaySystemIds;
         String _networkUuid;
         boolean _isL3Network;
    +    boolean _isVpc;
    +    boolean _isSharedNetwork;
         String _vpcName;
         String _vpcUuid;
         boolean _defaultEgressPolicy;
    -    Collection<String> _ipAddressRange;
    +    Collection<String[]> _ipAddressRange;
    +    String _domainTemplateName;
     
         public ImplementNetworkVspCommand(String networkDomainName, String networkDomainPath, String networkDomainUuid, String networkAccountName, String networkAccountUuid,
    -            String networkName, String networkCidr, String networkGateway, String networkUuid, boolean isL3Network, String vpcName, String vpcUuid, boolean defaultEgressPolicy,
    -            Collection<String> ipAddressRange) {
    +            String networkName, String networkCidr, String networkGateway, Long networkAclId, List<String> dnsServers, List<String> gatewaySystemIds, String networkUuid,
    +            boolean isL3Network, boolean isVpc, boolean isSharedNetwork, String vpcName, String vpcUuid, boolean defaultEgressPolicy, Collection<String[]> ipAddressRange,
    +            String domainTemplateName) {
    --- End diff --
    
    The number of parameters is extremely large -- creating a brittle interface and difficult to comprehend client client.  Please refactor to the Builder pattern (i.e. declare the builder a ``public static final`` inner class to create instances of ``ImplementNetworkVspCommand`` and declare the constructor of ``ImplementNetworkVspCommand`` ``private``). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---