Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: mike-tutkowski <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-816-cloudstack@git.apache.org>
In-Reply-To: <git-pr-816-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Notify listeners when a host has
 been add...
Content-Type: text/plain
Message-Id: <20150914134736.D151AE02DB@git1-us-west.apache.org>
Date: Mon, 14 Sep 2015 13:47:36 +0000 (UTC)

Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/816#issuecomment-140080679
  
    Hi Miguel,
    
    I can remove those commented-out lines. No problem. Some companies like such lines left in, but others - as you point out - like them removed and point to version control as sufficient documentation.
    
    As you noted, there were some places where I simply didn't see any value in being able to easily reference that info anyways, so I removed those lines. I can just do the same for all of them.
    
    I'm happy to add until tests, but it was not clear to me how to do so for this particular group of logic. Do you have any suggestions as to what specifically (and perhaps how) you'd like unit tested?
    
    Initially I had mainly planned on doing end-to-end integration testing on this code (along with many other pieces of code).
    
    Thanks!
    Mike


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---