Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: mike-tutkowski <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-816-cloudstack@git.apache.org>
In-Reply-To: <git-pr-816-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Notify listeners when a host has
 been add...
Content-Type: text/plain
Message-Id: <20150914131041.28F2CE03E6@git1-us-west.apache.org>
Date: Mon, 14 Sep 2015 13:10:41 +0000 (UTC)

Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/816#discussion_r39390966
  
    --- Diff: server/src/com/cloud/storage/upload/UploadListener.java ---
    @@ -270,7 +274,7 @@ public AgentControlAnswer processControlCommand(long agentId, AgentControlComman
         }
     
         public void setUploadInactive(Status reason) {
    -        uploadActive = false;
    +        // uploadActive = false;
    --- End diff --
    
    While making changes in this file, I noticed that Eclipse was pointing out that the variable uploadActive was only written to (never read from). Instead of removing the entire line, I just commented it out in case someone later wanted to easily resume making use of this variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---