Return-Path: 
 <dev-return-80306-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1981718D08
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Mon, 14 Sep 2015 13:08:07 +0000 (UTC)
Received: (qmail 64049 invoked by uid 500); 14 Sep 2015 13:08:06 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 63997 invoked by uid 500); 14 Sep 2015 13:08:06 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 63986 invoked by uid 99); 14 Sep 2015 13:08:06 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Sep 2015 13:08:06 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 44F01E03E6; Mon, 14 Sep 2015 13:08:06 +0000 (UTC)
From: mike-tutkowski <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-816-cloudstack@git.apache.org>
In-Reply-To: <git-pr-816-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Notify listeners when a host has
 been add...
Content-Type: text/plain
Message-Id: <20150914130806.44F01E03E6@git1-us-west.apache.org>
Date: Mon, 14 Sep 2015 13:08:06 +0000 (UTC)

Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/816#discussion_r39390723
  
    --- Diff: server/src/com/cloud/network/security/SecurityGroupListener.java ---
    @@ -81,7 +81,7 @@ public boolean isRecurring() {
         @Override
         public boolean processAnswers(long agentId, long seq, Answer[] answers) {
             List<Long> affectedVms = new ArrayList<Long>();
    -        int commandNum = 0;
    +        // int commandNum = 0;
    --- End diff --
    
    While making changes in this file, I noticed that Eclipse was pointing out that the variable commandNum was only written to (never read from). Instead of removing the entire line, I just commented it out in case someone later wanted to easily resume making use of this variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---