Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20ECC17C26 for ; Fri, 11 Sep 2015 12:25:14 +0000 (UTC) Received: (qmail 52339 invoked by uid 500); 11 Sep 2015 12:25:01 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 52288 invoked by uid 500); 11 Sep 2015 12:25:01 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 52277 invoked by uid 99); 11 Sep 2015 12:25:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2015 12:25:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B116DDFBD2; Fri, 11 Sep 2015 12:25:00 +0000 (UTC) From: DaanHoogland To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8835: Added alerts incase of t... Content-Type: text/plain Message-Id: <20150911122500.B116DDFBD2@git1-us-west.apache.org> Date: Fri, 11 Sep 2015 12:25:00 +0000 (UTC) Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/808#issuecomment-139532776 Makes sense and LGTM. I see some code duplication in ImageStoreUploadMonitorImpl, though. A good moment to get rid of this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---