Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: milamberspace <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-786-cloudstack@git.apache.org>
In-Reply-To: <git-pr-786-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change
Content-Type: text/plain
Message-Id: <20150908103150.16827DFAF1@git1-us-west.apache.org>
Date: Tue,  8 Sep 2015 10:31:50 +0000 (UTC)

Github user milamberspace commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/786#discussion_r38911089
  
    --- Diff: ui/scripts/network.js ---
    @@ -1612,6 +1613,36 @@
                                                         });
                                                     }
                                                 });
    +
    +                                            if (!isConfigRulesMsgShown) {
    +                                                isConfigRulesMsgShown = true;
    +                                                $.ajax({
    +                                                    url: createURL('listNetworkOfferings'),
    +                                                    data: {
    +                                                        id: args.context.networks[0].networkofferingid
    +                                                    },
    +                                                    dataType: 'json',
    +                                                    async: true,
    +                                                    success: function(json) {
    +                                                        var response = json.listnetworkofferingsresponse.networkoffering ?
    +                                                        json.listnetworkofferingsresponse.networkoffering[0] : null;
    +
    +                                                        if (response != null) {
    +                                                            var egressdefaultpolicy;
    +
    +                                                            if (response.egressdefaultpolicy == true) {
    +                                                                egressdefaultpolicy = 'Block';
    +                                                            } else {
    +                                                                egressdefaultpolicy = 'Allow';
    +                                                            }
    +
    +                                                            cloudStack.dialog.notice({
    +                                                                message: _l('Configure the rules to ' + egressdefaultpolicy + ' Traffic.')
    --- End diff --
    
    Would be great if you can use a localization key from messages.properties (by adding the sentence inside) instead of hard code message to allow the localization of the web UI. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---