Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: koushik-das <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-755-cloudstack@git.apache.org>
In-Reply-To: <git-pr-755-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and
 Autoimp...
Content-Type: text/plain
Message-Id: <20150902091502.61B0BDFD40@git1-us-west.apache.org>
Date: Wed,  2 Sep 2015 09:15:02 +0000 (UTC)

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/755#discussion_r38512226
  
    --- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
    @@ -2145,14 +2145,10 @@ private UserAccount getUserAccount(String username, String password, Long domain
                 s_logger.debug("Attempting to log in user: " + username + " in domain " + domainId);
             }
             UserAccount userAccount = _userAccountDao.getUserAccount(username, domainId);
    -        if (userAccount == null) {
    -            s_logger.warn("Unable to find an user with username " + username + " in domain " + domainId);
    -            return null;
    -        }
     
             boolean authenticated = false;
             HashSet<ActionOnFailedAuthentication> actionsOnFailedAuthenticaion = new HashSet<ActionOnFailedAuthentication>();
    -        User.Source userSource = userAccount.getSource();
    +        User.Source userSource = userAccount != null ? userAccount.getSource(): User.Source.UNKNOWN;
    --- End diff --
    
    Think about it from the perspective of authenticators. Can a new authenticator break this logic?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---