From dev-return-80097-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org  Fri Sep 11 12:16:08 2015
Return-Path: <dev-return-80097-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EEA0517BB8
	for <apmail-cloudstack-dev-archive@www.apache.org>; Fri, 11 Sep 2015 12:16:08 +0000 (UTC)
Received: (qmail 23764 invoked by uid 500); 11 Sep 2015 12:16:08 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 23707 invoked by uid 500); 11 Sep 2015 12:16:08 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 23695 invoked by uid 99); 11 Sep 2015 12:16:08 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2015 12:16:08 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 38B3CDFBD2; Fri, 11 Sep 2015 12:16:08 +0000 (UTC)
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-806-cloudstack@git.apache.org>
In-Reply-To: <git-pr-806-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8820: Showing error when try t...
Content-Type: text/plain
Message-Id: <20150911121608.38B3CDFBD2@git1-us-west.apache.org>
Date: Fri, 11 Sep 2015 12:16:08 +0000 (UTC)

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/806#discussion_r39265018
  
    --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
    @@ -152,13 +152,26 @@ public void connect(String url, String userName, String password) throws Excepti
             @SuppressWarnings("unchecked")
             Map<String, List<String>> headers = (Map<String, List<String>>)((BindingProvider)vimPort).getResponseContext().get(MessageContext.HTTP_RESPONSE_HEADERS);
             List<String> cookies = headers.get("Set-cookie");
    +
    +        vimPort.login(serviceContent.getSessionManager(), userName, password, null);
    +
    +        if (cookies == null) {
    +            @SuppressWarnings("unchecked")
    --- End diff --
    
    why suppress? please add a comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---