cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...
Date Tue, 22 Sep 2015 09:39:51 GMT
GitHub user karuturi opened a pull request:

    https://github.com/apache/cloudstack/pull/873

    CLOUDSTACK-8896: allocated percentage of storage pool going beyond 100%

    This issue occurs when a volume in Ready state is moved across storage
    pools.
    
    While finding if the storage pool has enough space, it has a check to
    consider the size of non Ready volumes only. This is true if the volume
    to be attached to a vm is in the same storage pool. But, if the volume
    is in another storage pool and has to be moved to a vm's storage pool,
    the size of the volume should be considered in doing the space check.
    
    computing the asking size when volume is not in ready state or when the 
    volume is on a different storage pool.
    
    Testing:
    I couldnt write unittests for it. This class is not in a unittestable state.
    
    manually tested in the below environment
    1. xenserver 6.5 setup with 2 clusters and a host each in each of them.
    2. added storage tags for the primary storage.
    3. created two service offerings with the storage tags.
    4. deployed two vms using newly created offerings in step 3.
    5. at this stage, there are two vms one on each host with root disks on the corresponding
primary.
    6. create a data disk and attach it to vm1
    7. detach the data disk. now the data disk is in the primary storage of the cluster of
vm1 (let us say primary1)
    8. attach this data disk to vm2(running on a host in different cluster)
    9. the volume should be moved to the primary storage of another cluster and op_host_capacity
should be accordingly updated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-8896

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #873
    
----
commit 5d8fd6e9acdc6b28d6a14b092290483614f412b3
Author: Rajani Karuturi <rajani.karuturi@citrix.com>
Date:   2015-09-22T09:27:38Z

    CLOUDSTACK-8896: allocated percentage of storage pool going beyond 100%
    
    This issue occurs when a volume in Ready state is moved across storage
    pools.
    
    While finding if the storage pool has enough space, it has a check to
    consider the size of non Ready volumes only. This is true if the volume
    to be attached to a vm is in the same storage pool. But, if the volume
    is in another storage pool and has to be moved to a vm's storage pool,
    the size of the volume should be considered in doing the space check.
    
    setting the asking size when volume is not in ready state or when on a
    different storage pool.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message