cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...
Date Mon, 21 Sep 2015 10:51:12 GMT
GitHub user karuturi opened a pull request:

    https://github.com/apache/cloudstack/pull/860

    CLOUDSTACK-8889: delete volume doesnt decrement primary store resource count

    Primary Storage count for an account does not decrease when a Data Disk
    is deleted belonging to the account unless the VM to which volume
    belonged is destroyed
    
    The resource counts are updated even before the disk is actually deleted
    resulting in the same value.
    Moved the resource counts updation to after the expunge operation as
    thats when the disk is actually deleted.
    
    Testing:
     Earlier, test_create_multiple_volumes in test/integration/component/test_ps_limits.py
failed  with error AssertionError: Resource count 37 should match with the expected resource
count 32
    
    Before
    
    Test create multiple volumes ... === TestName: test_create_multiple_volumes_1_root_domain_admin
| Status : FAILED ===
    FAIL
    Test create multiple volumes ... === TestName: test_create_multiple_volumes_2_child_domain_admin
| Status : FAILED ===
    FAIL
    
    After the Fix
    
    Test create multiple volumes ... === TestName: test_create_multiple_volumes_1_root_domain_admin
| Status : SUCCESS ===
    ok
    Test create multiple volumes ... === TestName: test_create_multiple_volumes_2_child_domain_admin
| Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 2 tests in 334.823s
    
    OK

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-8889

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #860
    
----
commit 4e56dfbfbfa82802f71717b333728d8b03d7892a
Author: Rajani Karuturi <rajani.karuturi@citrix.com>
Date:   2015-09-21T10:41:15Z

    CLOUDSTACK-8889: delete volume doesnt decrement primary store resource count
    
    Primary Storage count for an account does not decrease when a Data Disk
    is deleted belonging to the account unless the VM to which volume
    belonged is destroyed
    
    The resource counts are updated even before the disk is actually deleted
    resulting in the same value.
    Moved the resource counts updation to after the expunge operation as
    thats when the disk is actually deleted.
    
    all the tests in test/integration/component/test_ps_limits.py now pass

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message