cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From insom <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...
Date Fri, 18 Sep 2015 09:18:51 GMT
GitHub user insom opened a pull request:

    https://github.com/apache/cloudstack/pull/848

    Pass LbProtocol down to the HAProxyConfigurator

    This will let us specify a new load balancer protocol
    (tcp-proxy) which enables HAProxy's `send-proxy`
    functionality.
    
    `send-proxy` / the PROXY protocol[1] will send the real
    connection origin IP through to the servers behind HAProxy,
    without requiring any protocol specific changes (such as
    HTTP header rewriting).
    
    [1]: http://www.haproxy.org/download/1.5/doc/proxy-protocol.txt
    
    This is also inline with what Amazon ELB now supports[2].
    
    [2]: http://docs.aws.amazon.com/ElasticLoadBalancing/latest/DeveloperGuide/enable-proxy-protocol.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iwebhosting/cloudstack lbprotocol

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/848.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #848
    
----
commit 1a13dc2221d1794caed68b08ecea1586074823f1
Author: Aaron Brady <aaron@iweb.co.uk>
Date:   2015-09-17T09:56:38Z

    Pass LbProtocol down to the HAProxyConfigurator
    
    This will let us specify a new load balancer protocol
    (tcp-proxy) which enables HAProxy's `send-proxy`
    functionality.
    
    `send-proxy` / the PROXY protocol[1] will send the real
    connection origin IP through to the servers behind HAProxy,
    without requiring any protocol specific changes (such as
    HTTP header rewriting).
    
    [1]: http://www.haproxy.org/download/1.5/doc/proxy-protocol.txt
    
    This is also inline with what Amazon ELB now supports[2].
    
    [2]: http://docs.aws.amazon.com/ElasticLoadBalancing/latest/DeveloperGuide/enable-proxy-protocol.html

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message