cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudhansu7 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...
Date Thu, 10 Sep 2015 14:35:38 GMT
GitHub user sudhansu7 opened a pull request:

    https://github.com/apache/cloudstack/pull/799

    CLOUDSTACK-8815 : Issues with cloudstack-management init script

    
    
    When a management server is halted or rebooted, the cloudstack-management init script
does not successfully kill the associated java process. There will always be an error about
"Cannot find PID file". The script should be reworked so that there are no errors and java
is killed correctly.
    
    This appears to be due to the script using the basename of the script:
    
    NAME="$(basename $0)"
    
    To look for the pid file:
    
    if [ -f /var/run/$
    {NAME}
    
    .pid ]; then
    
    This does work correctly if the script is run directly (basename will be "cloudstack-management",
so "cloudstack-management.pid" file is found). However when a server is halted or rebooted,
the script is not run directly but via the symlinks in /etc/rc.d/rc0.d/ and /etc/rc.d/rc0.d/,
respectively. The symlinks are named "K20cloudstack-management" so the script looks for a
pid file named "K20cloudstack-management.pid" which does not exist.
    
    screenshots:
    
    Before fix: 
    ![screen shot 2015-09-10 at 12 33 08 am](https://cloud.githubusercontent.com/assets/1062642/9791113/207412f0-57f7-11e5-8d21-b7ef383747bd.png)
    
    After fix:
    ![screen shot 2015-09-10 at 5 46 50 pm](https://cloud.githubusercontent.com/assets/1062642/9791136/31c9ca90-57f7-11e5-98c5-9ad18f25788b.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudhansu7/cloudstack CLOUDSTACK-8815

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/799.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #799
    
----
commit 45ebfb0d2f81a55c0f9ab89abfd0cb1de0c7b57c
Author: Sudhansu <sudhansu.sahu@citrix.com>
Date:   2015-09-10T14:29:51Z

    CLOUDSTACK-8815 : Issues with cloudstack-management init script
    
    instead of using basename use target file.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message