cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [GitHub] cloudstack pull request: config: doc: add default value 10 in desc...
Date Mon, 07 Sep 2015 06:39:12 GMT
Rafael, and other non committing contributors,

committers are responsible for getting code merged and reverted if it
breaks things in hindsight but not the only and sometimes not even the best
people to judge code on its merits. Your opinion is very welcome to us all.

thanks for the valuable contribution of reviewing,
Daan

On Sat, Sep 5, 2015 at 1:48 AM, rafaelweingartner <git@git.apache.org>
wrote:

> Github user rafaelweingartner commented on the pull request:
>
>     https://github.com/apache/cloudstack/pull/777#issuecomment-137879562
>
>     I do not know if I can give LGTM (I am not a committer), but if I can
> +1 LGTM.
>     Errors in Jenkins are not related to this commit.
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message